Conversation
WE2-1240 Signed-off-by: Sven Mitt <svenzik@users.noreply.github.com>
mrts
requested changes
Sep 4, 2026
| private final boolean useSpaCsrfConfiguration; | ||
|
|
||
| public ApplicationConfiguration(@Value("${web-eid-auth-token.csrf.use-spa-configuration:false}") String useSpaCsrfConfiguration) { | ||
| this.useSpaCsrfConfiguration = Boolean.TRUE.toString().equalsIgnoreCase(useSpaCsrfConfiguration); |
Member
There was a problem hiding this comment.
We should assume that frontend and backend are served from different hosts or at least ports, so CORS must be configured as well along the lines of the following if useSpaCsrfConfiguration is enabled:
@Bean
@ConditionalOnProperty(
name = USE_SPA_CSRF_CONFIGURATION_PROPERTY, // see below
havingValue = "true"
)
CorsConfigurationSource corsConfigurationSource(YAMLConfig yamlConfig) {
CorsConfiguration configuration = new CorsConfiguration();
configuration.setAllowedOrigins(List.of(yamlConfig.getLocalOrigin()));
configuration.setAllowedMethods(List.of("GET", "POST", "OPTIONS"));
configuration.setAllowedHeaders(List.of("Content-Type", "X-XSRF-TOKEN"));
configuration.setAllowCredentials(true);
UrlBasedCorsConfigurationSource source =
new UrlBasedCorsConfigurationSource();
source.registerCorsConfiguration("/**", configuration);
return source;
}CORS must be activated in the security filter chain as well in this case:
if (useSpaCsrfConfiguration) {
http.cors(Customizer.withDefaults());
}Also, extract the property to a constant to avoid duplication:
private static final String USE_SPA_CSRF_CONFIGURATION_PROPERTY =
"web-eid-auth-token.csrf.use-spa-configuration";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add spa support for CSRF by setting into cookie
Signed-off-by: Sven Mitt svenzik@users.noreply.github.com